swift: Pass C base compile options to swiftc #14296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
c392940 to
c97b55c
Compare
4 tasks
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
2 times, most recently
from
c5af688 to
e79331a
Compare
dcbaker
requested changes
Feb 28, 2025
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
e79331a to
31441b1
Compare
dcbaker
approved these changes
Feb 28, 2025
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
2 times, most recently
from
a3461bb to
d5df540
Compare
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
d5df540 to
be6623a
Compare
|
@2xsaiko can you rebase to check it the ci failure goes away? |
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
be6623a to
f1c7bf3
Compare
|
Failure is unrelated. |
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
2 times, most recently
from
1e29c7d to
88f6478
Compare
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
88f6478 to
5b9a75e
Compare
dcbaker
approved these changes
May 1, 2025
|
@2xsaiko this looks good, and we're past the release freeze, if you can rebase this I'll go ahead and merge. |
|
Oh, just noticed! Should this be added in get_option_compile_args and not get_option_std_args since that's the method it also calls? EDIT: or actually, I think this should just call get_option_std_args here since that's what actually adds the -std option. Did this change recently? EDIT 2: Actually, let me add some tests as well so this does not happen in the future… |
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
148672c to
8478709
Compare
|
@2xsaiko hopefully last rebase to fix CI, please :) (Yes, the separate method for std was added recently to fix a CUDA bug. Thanks for adjusting) |
2xsaiko
force-pushed
the
push-uxoqqoqywmwu
branch
from
8478709 to
080246a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the C/Obj-C source code needs a particular standard version, swiftc should know about it so it can parse imported headers correctly.
(This makes more sense with C++ support (commit 2xsaiko@push-nmuxysxxokuy), since setting the standard version is more common there, and was pulled out of #14261, but still applies for C as well)