Fix compiler/linker interface assumptions for swiftc #14314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2xsaiko
force-pushed
the
push-kzxwtoyzyyot
branch
from
0682685 to
38be825
Compare
4 tasks
2xsaiko
force-pushed
the
push-kzxwtoyzyyot
branch
from
38be825 to
77db28e
Compare
Not all compilers (swiftc in this case) concatenate linker arguments with ','. This removes that assumption and instead always passes the arguments in a list where applicable. Some Apple ld arguments, notably -install_name, are also not exposed directly on the compiler options interface, hence add the linker prefix here.
2xsaiko
force-pushed
the
push-kzxwtoyzyyot
branch
from
77db28e to
70416f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #14261, needed to make Swift compilation use the generic C/... code path.
Not all compilers (swiftc in this case) concatenate linker arguments with ','. This removes that assumption and instead always passes the arguments in a list where applicable.
Some Apple ld arguments, notably -install_name, are also not exposed directly on the compiler options interface, hence add the linker prefix here.