improve and unify logging for sanity checks #14379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
fix14373
branch
2 times, most recently
from
d7128f0 to
211a5ac
Compare
dcbaker
approved these changes
Mar 17, 2025
bruchar1
reviewed
Mar 17, 2025
eli-schwartz
requested changes
Mar 24, 2025
thesamesam
approved these changes
Mar 25, 2025
|
I think it looks fine apart from what Eli's mentioned. |
Particularly if using an exe_wrapper, it can be useful to have output logged for debugging. Signed-off-by: Paolo Bonzini <[email protected]>
Avoid reinventing the wheel and instead use a single helper, taking care of logging and cross compilation. Fixes: mesonbuild#14373 Signed-off-by: Paolo Bonzini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for compiler sanity checks is duplicated across all languages. Improve it across the board by introducing a new helper function that handles cross compilation, logging and exception reporting.