Merged
Conversation
xclaesse
reviewed
Oct 5, 2021
xclaesse
reviewed
Oct 5, 2021
xclaesse
reviewed
Oct 5, 2021
xclaesse
reviewed
Oct 5, 2021
xclaesse
reviewed
Oct 5, 2021
Member
|
@thiblahute Has this been proposed upstream? |
Contributor
Author
Yes: mstorsjo/fdk-aac#139 |
bb2a5fd to
ed861ea
Compare
xclaesse
reviewed
Oct 5, 2021
xclaesse
reviewed
Oct 5, 2021
eli-schwartz
reviewed
Oct 5, 2021
eli-schwartz
reviewed
Oct 5, 2021
Member
|
From cmake: if(WIN32)
target_sources(aac-enc PRIVATE win32/getopt.h)
target_include_directories(aac-enc PRIVATE win32)
endif()Windows CI fails due to: |
eli-schwartz
reviewed
Oct 5, 2021
Member
|
Most of the time that means your dll does not export any symbol. Check if cmake has a .def file, or some macro defined to dllexport. |
Member
|
Looks all good to me now, and CI passed \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.