-
Notifications
You must be signed in to change notification settings - Fork 21
ci: add ci to create and publish doca-ofed driver #4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f4c5c81 to
b8fb227
Compare
|
b8fb227 to
a116db5
Compare
a116db5 to
a087345
Compare
|
|
||
| # Config | ||
| DOCA_BUILD_REPO := "Mellanox/doca-driver-build" | ||
| DOCA_BUILD_COMMIT := "661561f9969516748c35235e15bda27216807152" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can "latest" be used here? or this will have to be maintained incase of newer commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.nvidia.com/networking/display/kubernetes25100/advanced/doca-drivers.html#download-docker-files-and-scripts
in official doc also they have provided a commit hash , unfortunately the one they have provided have bug , so have picked a recent one where the script is working fine
they are not maintaining any release or tag , therefore for now the best we can do is stick to a commit which work for us
just/publish-doca-ofed-driver.just
Outdated
| # Map Linux distribution to Dockerfile name | ||
| _dockerfile-for distro: | ||
| @case "{{ distro }}" in \ | ||
| rhcos4.16) echo "RHEL_Dockerfile" ;; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think for now, ubuntu only is sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , can remove the extra handling
| @echo " Image tag: $(just _image-tag '{{ doca_version }}' '{{ ofed_version }}' '{{ kernel_version }}' '{{ linux_distro }}' '{{ arch }}')" | ||
| @echo " Dockerfile: $(just _dockerfile-for '{{ linux_distro }}')" | ||
| @echo " Linux distro: {{ linux_distro }}" | ||
| @echo " Arch: {{ arch }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can only be amd64 or arm64 right? I am thinking if we need this input or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D_ARCH: Target architecture: x86_64 or aarch64.
ref: https://docs.nvidia.com/networking/display/kubernetes25100/advanced/doca-drivers.html#specific-build-parameters
Pull Request Test Coverage Report for Build 20454786376Details
💛 - Coveralls |
|
great work! let's move this to https://github.com/mesosphere/dkp-container-images |
What problem does this PR solve?:
steps to create a doca-ofed driver https://docs.google.com/document/d/1n8A1f3AWr1sZ1RK1Ggq65MkHk-eHgQAJ2W4E29yuCnM/edit?usp=sharing
this ci perform the above operation, this driver is needed for nvidia network operator
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-111527
Does this PR introduce a user-facing change?:
Checklist