Fix incorrect import in download CLI causing ModuleNotFoundError#476
Open
YADAV1825 wants to merge 1 commit into
Open
Fix incorrect import in download CLI causing ModuleNotFoundError#476YADAV1825 wants to merge 1 commit into
YADAV1825 wants to merge 1 commit into
Conversation
YADAV1825
requested review from
ashwinb,
ehhuang,
hardikjshah and
raghotham
as code owners
April 15, 2026 11:28
meta-cla
Bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
Fixes a broken import in the download CLI that caused ModuleNotFoundError when running llama-model download.
Changes:
- Updated
download.pyto importsafety_modelsfrom the correct module location (.safety_modelsinstead of.model.safety_models).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475
Issue
Running:
llama-model download ...
Results in:
ModuleNotFoundError: No module named 'llama_models.cli.model'
Root Cause
The code imports from
.model.safety_models, but themodelsubmodule does not exist.safety_models.pyis located directly undermodels/cli/.Fix
Updated import from:
to:
Verification
Before
ModuleNotFoundError: No module named 'llama_models.cli.model'
After
CLI runs successfully and prompts for download URL