feat(providers): implement ProviderContext for portable storage directory #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
rhuss
force-pushed
the
feature/provider-context
branch
from
f1c18ac to
6e5cde7
Compare
- Introduce ProviderContext class to decouple provider storage paths from absolute paths - Add storage_dir attribute to StackRunConfig to accept CLI options - Implement storage directory resolution with prioritized fallbacks: 1. CLI option (--state-directory) 2. Environment variable (LLAMA_STACK_STATE_DIR) 3. Default distribution directory - Standardize provider signatures to follow context, config, deps pattern - Update provider implementations to use the new context-based approach - Add comprehensive tests to verify state directory resolution
rhuss
force-pushed
the
feature/provider-context
branch
from
a89ded7 to
e6c9aeb
Compare
rhuss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This PR implements #2139 but generalizes to separate runtime environments/contexts from specific provider configuration]
This PR introduces a new
ProviderContextobject that decouples execution environment concerns from provider configuration. In this first iteration, theProviderContextis used to introduce storage directory which providers should use as base directory (e.g. for SQLite dbs). This allows removing absolute paths from templates and make the whole distribution more portable across environments. E.g. the current default to store everything in~/.llamamight be difficult to use in a containerized environment where the notion of a $HOME directory might differ from base image to base image.Solution Details
ProviderContextclass that encapsulates runtime environment information- Updated provider interfaces to follow a consistent
context, config, depspattern--storage-dir)LLAMA_STACK_STORAGE_DIR)Note
Next Steps