feat: introduce OAuth2TokenAuthProvider and notion of "principal" #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan and
leseb
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
changed the title
ashwinb
changed the title
ashwinb
commented
May 16, 2025
grs
reviewed
May 16, 2025
grs
reviewed
May 16, 2025
grs
reviewed
May 16, 2025
grs
reviewed
May 16, 2025
ashwinb
commented
May 18, 2025
| @@ -31,6 +31,7 @@ dependencies = [ | |||
| "openai>=1.66", | |||
| "prompt-toolkit", | |||
| "python-dotenv", | |||
| "python-jose", | |||
There was a problem hiding this comment.
not happy about this right now, I am going to split off Auth (and then Credentials) to proper APIs which have proper providers so the overall distribution dependency system takes over. we dont want starter distros to have complex dependencies if they don't need them.
but for now, this will do.
ashwinb
changed the title
raghotham
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a notion of
principal(aka some kind of persistent identity) to the authentication infrastructure of the Stack. Until now we only used access attributes ("claims" in the more standard OAuth / OIDC setup) but we need the notion of a User fundamentally as well. (Thanks @rhuss for bringing this up.)This value is not yet used anywhere downstream but will be used to segregate access to resources.
In addition, the PR introduces a built-in JWT token validator so the Stack does not need to contact an authentication provider to validating the authorization and merely check the signed token for the represented claims. Public keys are refreshed via the configured JWKS server. This Auth Provider should overwhelmingly be considered the default given the seamless integration it offers with OAuth setups.