feat: export distribution container build artifacts #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
force-pushed
the
build-export
branch
6 times, most recently
from
dcf3c02 to
c151c80
Compare
Add a new --export-dir flag to the `llama stack build` command that allows users to export container build artifacts to a specified directory instead of building the container directly. This feature is useful for: - Building containers in different environments - Sharing build configurations - Customizing the build process The exported tarball includes: - Containerfile (Dockerfile) - Run configuration file (if building from config) - External provider files (if specified) - Build script for assistance The tarball is named with a timestamp for uniqueness: <distro-name>_<timestamp>.tar.gz Documentation has been updated in building_distro.md to reflect this new functionality as well as integration tests. Signed-off-by: Sébastien Han <[email protected]>
ashwinb
requested changes
May 16, 2025
| @@ -270,6 +273,50 @@ printf "Containerfile created successfully in %s/Containerfile\n\n" "$TEMP_DIR" | |||
| cat "$TEMP_DIR"/Containerfile | |||
| printf "\n" | |||
|
|
|||
| # If export_dir is specified, copy all necessary files and exit | |||
There was a problem hiding this comment.
this script is getting very large. I think at the very least we can make this section into a function perhaps?
| # Create the archive with all files | ||
| echo "Creating tarball with the following files:" | ||
| echo "- Containerfile" | ||
| [ -n "$run_config" ] && echo "- run.yaml" |
There was a problem hiding this comment.
nice one liners
edit: although the conditionals get repeated. can you add the echo as you are building the tar_cmd?
| ;; | ||
| *) | ||
| # Check if argument is a valid directory path (export_dir) or special_pip_deps | ||
| if [[ "$1" == *" "* ]] || ! mkdir -p "$1" 2>/dev/null; then |
There was a problem hiding this comment.
hm what is this? this looks very dangerous. why are we doing mkdir -p for checking?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new --export-dir flag to the
llama stack buildcommand that allows users to export container build artifacts to a specified directory instead of building the container directly. This feature is useful for:The exported tarball includes:
The tarball is named with a timestamp for uniqueness: _.tar.gz
Documentation has been updated in building_distro.md to reflect this new functionality as well as integration tests.
Test Plan