Skip to content

fix: validate empty generation batches #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danyalahmed1995 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix: validate empty generation batches #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llama/generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ def text_completion(
If logprobs is True, token log probabilities are computed for each generated token.

"""
if not prompts:
return []
if max_gen_len is None:
max_gen_len = self.model.params.max_seq_len - 1
prompt_tokens = [self.tokenizer.encode(x, bos=True, eos=False) for x in prompts]
Expand Down Expand Up @@ -313,6 +315,10 @@ def chat_completion(
If logprobs is True, token log probabilities are computed for each generated token.

"""
if not dialogs:
return []
if any([len(dialog) == 0 for dialog in dialogs]):
raise ValueError("dialogs must not contain empty dialogs")
if max_gen_len is None:
max_gen_len = self.model.params.max_seq_len - 1
prompt_tokens = []
Expand Down