-
Notifications
You must be signed in to change notification settings - Fork 174
Fix docker build commands and Dockerfile for base image
#310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @liopeer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@greptile |
Greptile Summary
Important Files Changed
Confidence score: 2/5
Sequence DiagramsequenceDiagram
participant User
participant Docker
participant BaseImage as "Base Image Build"
participant EnvImage as "Environment Image Build"
participant Registry as "Image Registry"
User->>Docker: "docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile ."
Docker->>BaseImage: "Build base image from Dockerfile"
BaseImage->>BaseImage: "Install system dependencies (curl, ca-certificates)"
BaseImage->>BaseImage: "Copy uv from builder stage"
BaseImage->>BaseImage: "Set environment variables (PYTHONPATH, etc.)"
BaseImage->>Docker: "Base image ready"
Docker->>User: "openenv-base:latest created"
User->>Docker: "docker build -t env-image:latest -f envs/*/server/Dockerfile ."
Docker->>EnvImage: "Build environment image"
EnvImage->>Registry: "Pull base image (openenv-base:latest)"
Registry->>EnvImage: "Base image layers"
EnvImage->>EnvImage: "Install environment-specific dependencies"
EnvImage->>EnvImage: "Copy environment source code"
EnvImage->>EnvImage: "Set CMD for FastAPI server"
EnvImage->>Docker: "Environment image ready"
Docker->>User: "env-image:latest created"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (4)
-
envs/chat_env/server/Dockerfile, line 29 (link)logic: This COPY path is inconsistent with the updated build comment. Line 29 references
src/core/but the correct path should besrc/openenv/core/to match the repository structure. This will cause Docker builds to fail. -
envs/snake_env/server/Dockerfile.backup, line 14 (link)logic: The path
src/envs/snake_env/server/requirements.txtappears incorrect - it should beenvs/snake_env/server/requirements.txtbased on the repository structure -
envs/snake_env/server/Dockerfile.backup, line 18-19 (link)logic: The paths
src/core/andsrc/envs/snake_env/are inconsistent with the actual repository structure where environments are atenvs/snake_env/and core is atsrc/openenv/core/ -
envs/snake_env/server/Dockerfile.backup, line 22 (link)logic: The path
src/envs/snake_env/README.mdshould beenvs/snake_env/README.mdto match the repository structure
7 files reviewed, 4 comments
Summary
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
Try to run
docker build -t openenv-base:latest -f src/core/containers/images/Dockerfile .and then run
docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile .Claude Code Review