Skip to content

Conversation

@targeted-DK
Copy link

@targeted-DK targeted-DK commented Jan 25, 2026

Summary

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • New environment
  • Refactoring

Alignment Checklist

Before submitting, verify:

  • I have read .claude/docs/PRINCIPLES.md and this PR aligns with our principles
  • I have checked .claude/docs/INVARIANTS.md and no invariants are violated
  • I have run /pre-submit-pr (or bash .claude/hooks/lint.sh and tests) and addressed all issues

RFC Status

  • Not required (bug fix, docs, minor refactoring)
  • RFC exists: #___
  • RFC needed (will create before merge)

Test Plan

I verified the path fix by running a full build of the base image for finrl_env. Since the previous COPY path was broken, the build used to fail at step 3. With this fix, it completes successfully.

Command: docker build -t envtorch-base:latest -f ./src/openenv/core/containers/images/Dockerfile .

Claude Code Review

NA

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 25, 2026
@greptile-apps
Copy link

greptile-apps bot commented Jan 25, 2026

Greptile Overview

Greptile Summary

Fixed broken COPY path in base Dockerfile from non-existent src/core/pyproject.toml to correct pyproject.toml at repository root.

  • Path change corrects build failure at step 3 where COPY command couldn't find source files
  • Comment on line 14 still references outdated Dockerfile path and should be updated
  • No architectural changes, invariants, or security concerns

Confidence Score: 5/5

  • Safe to merge - straightforward bug fix with verified path correction
  • Simple path fix in Dockerfile correcting a broken COPY command. Author verified fix by successfully building the image. Only issue is an outdated comment reference.
  • No files require special attention - single-line fix is correct

Important Files Changed

Filename Overview
src/openenv/core/containers/images/Dockerfile Fixed broken COPY path from src/core/pyproject.toml to pyproject.toml - simple bug fix, no issues found

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Docker as Docker Build
    participant Repo as Repository Root
    participant Dockerfile as Dockerfile

    Dev->>Docker: docker build -f src/openenv/core/containers/images/Dockerfile .
    Docker->>Dockerfile: Read build instructions
    Dockerfile->>Repo: COPY pyproject.toml uv.lock* ./
    Repo-->>Dockerfile: ✓ Files copied (fixed path)
    Dockerfile->>Docker: RUN uv pip install --system -r pyproject.toml
    Docker-->>Dev: ✓ Image built successfully
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Jan 25, 2026

Additional Comments (1)

src/openenv/core/containers/images/Dockerfile
outdated path in comment - should be -f src/openenv/core/containers/images/Dockerfile

# Build from repo root: docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile .
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/openenv/core/containers/images/Dockerfile
Line: 14:14

Comment:
outdated path in comment - should be `-f src/openenv/core/containers/images/Dockerfile`

```suggestion
# Build from repo root: docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile .
```

How can I resolve this? If you propose a fix, please make it concise.

@targeted-DK targeted-DK changed the title fix(core): update pyproject.toml path in base Dockerfile fix: update pyproject.toml path in base Dockerfile Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant