Add retries to optimize_with_nsgaii
#3116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen that NSGA-II does not find any feasible solutions, in which case it will return `None` as the results `X` attribute. This breaks the current code with a `TypeError`. This also led to flaky unit tests, see e.g. here; https://github.com/meta-pytorch/botorch/actions/runs/20408594090/job/58641991612 This PR adds a `num_retries` input to `optimize_with_nsgaii` to increase robustness. This should fix the flaky unit tests.
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 219 219
Lines 21174 21253 +79
=======================================
+ Hits 21172 21251 +79
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Balandat
force-pushed
the
fix_nsgaii_test_failure
branch
from
05e539c to
f3bcd45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that NSGA-II does not find any feasible solutions, in which case it will return
Noneas the resultsXattribute. This breaks the current code with aTypeError. This also led to flaky unit tests, see e.g. here; https://github.com/meta-pytorch/botorch/actions/runs/20408594090/job/58641991612This PR adds a
max_attemptsinput tooptimize_with_nsgaiito increase robustness. This should fix the flaky unit tests.