q-dim bugfix in ScalarizedPosteriorMean#3191
Closed
hvarfner wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3191 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 219 219
Lines 21414 21416 +2
=======================================
+ Hits 21413 21415 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
082c8a2 to
de59dc0
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 20, 2026
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions. Reviewed By: saitcakmak Differential Revision: D93691048
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 20, 2026
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions. Reviewed By: saitcakmak Differential Revision: D93691048
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 20, 2026
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions. Reviewed By: saitcakmak Differential Revision: D93691048
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions. Reviewed By: saitcakmak Differential Revision: D93691048
de59dc0 to
6fdf8ea
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 20, 2026
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions. Reviewed By: saitcakmak Differential Revision: D93691048
|
This pull request has been merged in 3decde5. |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 4, 2026
Summary: [botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions This diff prepares the 0.17.1 release of BoTorch with the following changes: **Bug Fixes** - Fix BAxUS bugs (meta-pytorch#3204) - Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191) - Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205) **Other Changes** - Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203) - Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192) - Fix typos and docstring issues across botorch (meta-pytorch#3211) - Fix docstring issues in analytic acquisition functions (meta-pytorch#3208) **Compatibility** - Require GPyTorch>=1.15.2 and linear_operator>=0.6.1 Differential Revision: D95224716
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 4, 2026
…eta-pytorch#3214) Summary: [botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions This diff prepares the 0.17.1 release of BoTorch with the following changes: **Bug Fixes** - Fix BAxUS bugs (meta-pytorch#3204) - Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191) - Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205) **Other Changes** - Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203) - Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192) - Fix typos and docstring issues across botorch (meta-pytorch#3211) - Fix docstring issues in analytic acquisition functions (meta-pytorch#3208) **Compatibility** - Require GPyTorch>=1.15.2 and linear_operator>=0.6.1 Reviewed By: saitcakmak Differential Revision: D95224716
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 4, 2026
…eta-pytorch#3214) Summary: Pull Request resolved: meta-pytorch#3214 [botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions This diff prepares the 0.17.1 release of BoTorch with the following changes: **Bug Fixes** - Fix BAxUS bugs (meta-pytorch#3204) - Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191) - Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205) **Other Changes** - Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203) - Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192) - Fix typos and docstring issues across botorch (meta-pytorch#3211) - Fix docstring issues in analytic acquisition functions (meta-pytorch#3208) **Compatibility** - Require GPyTorch>=1.15.2 and linear_operator>=0.6.1 Reviewed By: saitcakmak Differential Revision: D95224716
meta-codesync Bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
…3214) Summary: Pull Request resolved: #3214 [botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions This diff prepares the 0.17.1 release of BoTorch with the following changes: **Bug Fixes** - Fix BAxUS bugs (#3204) - Fix q-dim bug in `ScalarizedPosteriorMean` (#3191) - Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (#3205) **Other Changes** - Make `d` and `target_fidelities` required in `project_to_target_fidelity` (#3203) - Add test harness infrastructure for acquisition function testing (#3190, #3192) - Fix typos and docstring issues across botorch (#3211) - Fix docstring issues in analytic acquisition functions (#3208) **Compatibility** - Require GPyTorch>=1.15.2 and linear_operator>=0.6.1 Reviewed By: saitcakmak Differential Revision: D95224716 fbshipit-source-id: 311d7abe2b389ee62df4eeaf3951d2c90733eee5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.
Differential Revision: D93691048