Skip to content

q-dim bugfix in ScalarizedPosteriorMean#3191

Closed
hvarfner wants to merge 1 commit into
meta-pytorch:mainfrom
hvarfner:export-D93691048
Closed

q-dim bugfix in ScalarizedPosteriorMean#3191
hvarfner wants to merge 1 commit into
meta-pytorch:mainfrom
hvarfner:export-D93691048

Conversation

@hvarfner
Copy link
Copy Markdown
Contributor

Summary: Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Differential Revision: D93691048

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 19, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 19, 2026

@hvarfner has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93691048.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.99%. Comparing base (bad715c) to head (6fdf8ea).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3191   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         219      219           
  Lines       21414    21416    +2     
=======================================
+ Hits        21413    21415    +2     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Feb 20, 2026
Summary:

Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Reviewed By: saitcakmak

Differential Revision: D93691048
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Feb 20, 2026
Summary:

Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Reviewed By: saitcakmak

Differential Revision: D93691048
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Feb 20, 2026
Summary:

Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Reviewed By: saitcakmak

Differential Revision: D93691048
Summary:

Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Reviewed By: saitcakmak

Differential Revision: D93691048
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Feb 20, 2026
Summary:

Fixes ScalarizedPosteriorMean to correctly reduce over the q-dimension, ensuring consistent behavior with other analytic acquisition functions.

Reviewed By: saitcakmak

Differential Revision: D93691048
@meta-codesync meta-codesync Bot closed this in 3decde5 Feb 20, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 20, 2026

This pull request has been merged in 3decde5.

sdaulton added a commit to sdaulton/botorch that referenced this pull request Mar 4, 2026
Summary:
[botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions


This diff prepares the 0.17.1 release of BoTorch with the following changes:

**Bug Fixes**
- Fix BAxUS bugs (meta-pytorch#3204)
- Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191)
- Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205)

**Other Changes**
- Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203)
- Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192)
- Fix typos and docstring issues across botorch (meta-pytorch#3211)
- Fix docstring issues in analytic acquisition functions (meta-pytorch#3208)

**Compatibility**
- Require GPyTorch>=1.15.2 and linear_operator>=0.6.1

Differential Revision: D95224716
sdaulton added a commit to sdaulton/botorch that referenced this pull request Mar 4, 2026
…eta-pytorch#3214)

Summary:

[botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions


This diff prepares the 0.17.1 release of BoTorch with the following changes:

**Bug Fixes**
- Fix BAxUS bugs (meta-pytorch#3204)
- Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191)
- Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205)

**Other Changes**
- Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203)
- Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192)
- Fix typos and docstring issues across botorch (meta-pytorch#3211)
- Fix docstring issues in analytic acquisition functions (meta-pytorch#3208)

**Compatibility**
- Require GPyTorch>=1.15.2 and linear_operator>=0.6.1

Reviewed By: saitcakmak

Differential Revision: D95224716
sdaulton added a commit to sdaulton/botorch that referenced this pull request Mar 4, 2026
…eta-pytorch#3214)

Summary:
Pull Request resolved: meta-pytorch#3214

[botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions

This diff prepares the 0.17.1 release of BoTorch with the following changes:

**Bug Fixes**
- Fix BAxUS bugs (meta-pytorch#3204)
- Fix q-dim bug in `ScalarizedPosteriorMean` (meta-pytorch#3191)
- Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (meta-pytorch#3205)

**Other Changes**
- Make `d` and `target_fidelities` required in `project_to_target_fidelity` (meta-pytorch#3203)
- Add test harness infrastructure for acquisition function testing (meta-pytorch#3190, meta-pytorch#3192)
- Fix typos and docstring issues across botorch (meta-pytorch#3211)
- Fix docstring issues in analytic acquisition functions (meta-pytorch#3208)

**Compatibility**
- Require GPyTorch>=1.15.2 and linear_operator>=0.6.1

Reviewed By: saitcakmak

Differential Revision: D95224716
meta-codesync Bot pushed a commit that referenced this pull request Mar 4, 2026
…3214)

Summary:
Pull Request resolved: #3214

[botorch] Release 0.17.1 - Bump pinned gpytorch and linear_operator versions

This diff prepares the 0.17.1 release of BoTorch with the following changes:

**Bug Fixes**
- Fix BAxUS bugs (#3204)
- Fix q-dim bug in `ScalarizedPosteriorMean` (#3191)
- Project `candidate_set` in `qMultiFidelityMaxValueEntropy.__init__` (#3205)

**Other Changes**
- Make `d` and `target_fidelities` required in `project_to_target_fidelity` (#3203)
- Add test harness infrastructure for acquisition function testing (#3190, #3192)
- Fix typos and docstring issues across botorch (#3211)
- Fix docstring issues in analytic acquisition functions (#3208)

**Compatibility**
- Require GPyTorch>=1.15.2 and linear_operator>=0.6.1

Reviewed By: saitcakmak

Differential Revision: D95224716

fbshipit-source-id: 311d7abe2b389ee62df4eeaf3951d2c90733eee5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants