Add input constructor harness#3206
Open
hvarfner wants to merge 3 commits into
Open
Conversation
added 3 commits
February 24, 2026 14:04
Summary: New year's sprint task Adds test harness infrastructure for acquisition function testing, including factory functions (make_mock_model, make_X, make_trained_gp), a spec dataclass (AcquisitionSpec), and test mixins. Analytic acquisition functions (EI, LogEI, PI, LogPI, UCB, PosteriorMean, PosteriorStandardDeviation) now use a shared AnalyticAcquisitionTestMixin for dtype, batch-shape, and output-shape tests. Differential Revision: D93691051
Summary: New year's sprint task MC acquisition functions (qEI, qLogEI, qPI, qUCB, qSimpleRegret, qPSTD, qNEI, qLogNEI) now use a shared test harness for dtype, shape, and q-batch tests, x_pending etc. Differential Revision: D93691036
Differential Revision: D93790262
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 99.99% 99.98% -0.01%
==========================================
Files 219 219
Lines 21417 21417
==========================================
- Hits 21416 21414 -2
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D93790262