Skip to content

Fix test_cuda failure: use BotorchTestCase for TestBetaPrior#3274

Open
hvarfner wants to merge 1 commit into
meta-pytorch:mainfrom
hvarfner:export-D100337776
Open

Fix test_cuda failure: use BotorchTestCase for TestBetaPrior#3274
hvarfner wants to merge 1 commit into
meta-pytorch:mainfrom
hvarfner:export-D100337776

Conversation

@hvarfner
Copy link
Copy Markdown
Contributor

Summary:
TestBetaPrior extends unittest.TestCase instead of BotorchTestCase, which causes test_cuda.py to hit a ValueError. The test_cuda dispatcher only handles BotorchTestCase, TestSuite, self-reference, and _FailedTest — plain unittest.TestCase hits the else branch and raises.

Switch to BotorchTestCase for consistency with the rest of the test suite.

Differential Revision: D100337776

Summary:
TestBetaPrior extends unittest.TestCase instead of BotorchTestCase, which causes test_cuda.py to hit a ValueError. The test_cuda dispatcher only handles BotorchTestCase, TestSuite, self-reference, and _FailedTest — plain unittest.TestCase hits the else branch and raises.

Switch to BotorchTestCase for consistency with the rest of the test suite.

Differential Revision: D100337776
@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 10, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Apr 10, 2026

@hvarfner has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100337776.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (db3a00a) to head (00a0a09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         221      221           
  Lines       21926    21926           
=======================================
  Hits        21922    21922           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant