Skip to content

Pin numpy<2 in test_stable min-req job for torch <2.4 #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saitcakmak wants to merge 2 commits into from
Closed

Pin numpy<2 in test_stable min-req job for torch <2.4 #3310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7d46f
Pin numpy<2 in test_stable min-req job for torch <2.4
saitcakmak May 27, 2026
02feb0d
Apply numpy<2 constraint to second uv pip install as well
saitcakmak May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test_stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ jobs:
min_torch_version=$(grep '"torch>=' pyproject.toml | sed 's/.*"torch>=\([^"]*\)".*/\1/')
# The earliest PyTorch version on Python 3.14 available for all OS is 2.9.0.
min_torch_version="$(if ${{ matrix.python-version == '3.14' }}; then echo "2.9.0"; else echo "${min_torch_version}"; fi)"
# Torch <2.4 was built against numpy 1.x and is ABI-incompatible with numpy 2.x.
numpy_constraint="$(if ${{ matrix.python-version == '3.14' }}; then echo ""; else echo "numpy<2"; fi)"
min_gpytorch_version=$(grep '"gpytorch>=' pyproject.toml | sed 's/.*"gpytorch>=\([^"]*\)".*/\1/')
min_linear_operator_version=$(grep '"linear_operator>=' pyproject.toml | sed 's/.*"linear_operator>=\([^"]*\)".*/\1/')
uv pip install "torch==${min_torch_version}" "gpytorch==${min_gpytorch_version}" "linear_operator==${min_linear_operator_version}"
uv pip install .[test]
uv pip install "torch==${min_torch_version}" "gpytorch==${min_gpytorch_version}" "linear_operator==${min_linear_operator_version}" ${numpy_constraint}
uv pip install .[test] ${numpy_constraint}
- name: Unit tests and coverage -- BoTorch
run: |
pytest -ra test/ --cov botorch/ --cov-report term-missing --cov-report xml:botorch_cov.xml
Expand Down
Loading