Optim-wip: Improve & fix LaplacianImage#967
Open
ProGamerGov wants to merge 30 commits intometa-pytorch:optim-wipfrom
Open
Optim-wip: Improve & fix LaplacianImage#967ProGamerGov wants to merge 30 commits intometa-pytorch:optim-wipfrom
ProGamerGov wants to merge 30 commits intometa-pytorch:optim-wipfrom
Conversation
* Improved `LaplacianImage` code as part of removing the ToDo comment. * Added `"same"` padding option to `GaussianSmoothing`.
* Improved the `NaturalImage` docs. * Also removed built-in clamp squash function. It's inclusion was an aesthetic choice, and it's easy enough for users to add on their own.
* Update images.py * Update images.py
…ouble It seems to occur in ToRGB on 3 different tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaplacianImagecode as part of removing the ToDo comment."same"padding option toGaussianSmoothing.NaturalImagedocs.torch.meshgridinGaussianSmoothingas it will be required in future PyTorch versions.self.assertEqualstoself.assertEqual.register_full_backward_hookinstead ofregister_backward_hookfor applicable tests, as the later is being depreciated.