dynamo + torchdeploy bug #265
Conversation
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs 1. Outputs of using dynamo + torchscript + deploy is inconsistent with using just torchscript. 2. Multithreading models which use dynamo run into errors with prims. The output of building and running `test_deploy_compat.cpp` (which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are [here](https://pastebin.com/vZxNsFJj). One can run these tests again by running ``` cd multipy python multipy/runtime/example/generate_examples.py python -m pip install -e . ./multipy/runtime/build/test_deploy_compat ``` [ghstack-poisoned]
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs 1. Outputs of using dynamo + torchscript + deploy is inconsistent with using just torchscript. 2. Multithreading models which use dynamo run into errors with prims. The output of building and running `test_deploy_compat.cpp` (which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are [here](https://pastebin.com/vZxNsFJj). One can run these tests again by running ``` cd multipy python multipy/runtime/example/generate_examples.py python -m pip install -e . ./multipy/runtime/build/test_deploy_compat ``` [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @PaliC! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Stack from ghstack (oldest at bottom):
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs
The output of building and running
test_deploy_compat.cpp(which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are here.One can run these tests again by running
Differential Revision: D41349350