extend EmptyDataloaderDetectorCallback to raise on empty predict loop#1039
Closed
galrotem wants to merge 1 commit into
Closed
extend EmptyDataloaderDetectorCallback to raise on empty predict loop#1039galrotem wants to merge 1 commit into
galrotem wants to merge 1 commit into
Conversation
Summary: In some cases users don't have enough items in their dataloader to get a batch on all ranks. In these cases, when using predict, the job will succeed but the output table will be empty. We have a callback to detect two subsequent train epochs with no steps, but for predict there's no such detection. In predict, there's only one epoch so we should raise if no steps were performed. Differential Revision: D87656691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In some cases users don't have enough items in their dataloader to get a batch on all ranks. In these cases, when using predict, the job will succeed but the output table will be empty.
We have a callback to detect two subsequent train epochs with no steps, but for predict there's no such detection. In predict, there's only one epoch so we should raise if no steps were performed.
Differential Revision: D87656691