Skip to content

Conversation

@NicolasHug
Copy link
Contributor

@NicolasHug NicolasHug commented Dec 12, 2025

This PR refactors most of our CI job. More refac will probably come later to finalize things.

It's easier to review these few commits individually:

  • ed5f8c5 puts our "install pytorch and maybe torchvision" logic in a separate script
  • 80aea14 installs test-dependencies in a separate script
  • 25e0b77 puts the ffmpeg installation as well as the torchcodec wheel install in separate scripts
  • ab32c0c removes docs.yaml to add the doc job as a dependency of the cuda job. This is more efficient: the doc job was building a wheel on its own. But that wheel was already created by the cuda job. The doc job now just depends on the wheel-building part of the cuda job. They still both run in parallel.

The rest of the commits are just attempts at fixing stuff (reordering some steps), which I think you can safely ignore

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 12, 2025
@NicolasHug NicolasHug changed the title Refactor installation of torch dependency Refactor CI jobs Dec 12, 2025
@NicolasHug NicolasHug marked this pull request as ready for review December 12, 2025 18:00

- name: Setup conda env
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what effect upgrading this version had? Perhaps we should update the remaining uses of miniconda@v2 in reference_resources.yaml and lint.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants