Robust ffmpeg major version getter #1211
Open
+14
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1211
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 70a9ed7 with merge base 85d1dad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Dan-Flores
commented
Jan 30, 2026
|
|
||
|
|
||
| with expose_ffmpeg_dlls(): | ||
| ffmpeg_major_version, core_library_path = load_torchcodec_shared_libraries() |
Contributor
Author
There was a problem hiding this comment.
This is where ffmpeg_major_version is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
get_ffmpeg_major_versionto get the major version fromload_torchcodec_shared_librariesto resolve #100.This function is used many times throughout our testing (code search), so we can verify that the skips are still occuring by checking conditionally skipped tests. For example, this encoder test is still skipped on FFmpeg 4.
Ideally, we would also migrate
get_ffmpeg_minor_version, but since it only has 3 uses (code search) it can be lower priority.