Fix flaky BarrierTest by handling duplicate entry points #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `_load_backend` function was crashing with `ValueError: too many values to unpack (expected 1)` when `entry_points()` returned multiple results for the same backend name. This can happen when multiple packages in a test binary register the same torchcomms backend entry point. Changed from tuple unpacking `(wheel,) = found` to `wheel = next(iter(found))` to gracefully handle this case by using the first matching entry point. Fixes T253323758 Differential Revision: D91865034
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
_load_backendfunction was crashing withValueError: too many values to unpack (expected 1)whenentry_points()returned multiple results forthe same backend name. This can happen when multiple packages in a test
binary register the same torchcomms backend entry point.
Changed from tuple unpacking
(wheel,) = foundtowheel = next(iter(found))to gracefully handle this case by using the first matching entry point.
Fixes T253323758
Differential Revision: D91865034