[FIX] Drop only the sample truncated instead of the entire group #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: instead of dropping all samples, we just set the adv of truncated samples to 0.
You may ask: why not just drop them?
Because if our bsz=8, and we drop 1, now we have only 7 samples, and the trainer may need to wait until the next batch to train on the previous one, but at this point, the replay buffer may evict older policies, we would have a mess
Test plan