Skip to content

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Apr 10, 2025

This updates the minimum version of torch to be 2.7.0. There's some important fixes in PyTorch 2.7 that avoid crashes and other slow behavior.

CI has been flaky recently in large part due to segfaults caused by bugs in 2.6.

Test plan:

CI

@d4l3k d4l3k requested a review from H-Huang April 10, 2025 22:56
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 10, 2025
@d4l3k d4l3k marked this pull request as draft April 11, 2025 02:18
@d4l3k d4l3k marked this pull request as ready for review April 22, 2025 19:07
sudo apt-get install -y protobuf-compiler
# use RC build
pip install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/test/cu128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the lint workflow need cuda?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for ProcessGroupNCCL

@d4l3k d4l3k merged commit b8ca71e into main Apr 22, 2025
10 of 11 checks passed
@d4l3k d4l3k deleted the d4l3k/ci_test branch April 25, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants