Skip to content

Conversation

@msaroufim
Copy link
Member

Fixes #151

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 16, 2025
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for sending this! Code looks good though one question on checkpointing behavior

@d4l3k d4l3k merged commit 4961e56 into meta-pytorch:main Apr 18, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add max retries to quorum to avoid live locks

3 participants