load/store outer optimizer state dict #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating diff in D83512078. |
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Sep 29, 2025
Summary: Pull Request resolved: meta-pytorch#277 Differential Revision: D83512078
tushar00jain
force-pushed
the
export-D83512078
branch
from
6881fe5 to
74be564
Compare
Contributor
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating diff in D83512078. |
tushar00jain
force-pushed
the
export-D83512078
branch
from
74be564 to
274e866
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Sep 29, 2025
Summary: Pull Request resolved: meta-pytorch#277 Differential Revision: D83512078
Contributor
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating diff in D83512078. |
tushar00jain
force-pushed
the
export-D83512078
branch
from
274e866 to
c8eb891
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Sep 30, 2025
Summary: We don't restore outer optimizer state currently which can lead to bumps in loss because of high learning rate from a new replica. So save the outer optimizer state in the diloco specific state dict. Differential Revision: D83512078
Contributor
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83512078. |
Summary: We don't restore outer optimizer state currently which can lead to bumps in loss because of high learning rate from a new replica. So save the outer optimizer state in the diloco specific state dict. Reviewed By: d4l3k Differential Revision: D83512078
tushar00jain
force-pushed
the
export-D83512078
branch
from
c8eb891 to
2e4d93a
Compare
Contributor
|
This pull request has been merged in 302fd39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D83512078