setup basic otel logging #281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84571482. |
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 14, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
d122b77 to
84e042b
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 14, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
84e042b to
2c24479
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 14, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
2c24479 to
24c8fd1
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 14, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
24c8fd1 to
9c7ee3a
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 14, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
9c7ee3a to
52c6dbc
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 15, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
52c6dbc to
6e5fdf1
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 15, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
6e5fdf1 to
678ac56
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 16, 2025
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Reviewed By: d4l3k Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
678ac56 to
3e6643b
Compare
Summary: - setup 3 basic structured logs - quorums: every time a rank changes quorum id - commits: every time a rank commits a step - errors: every time a rank calls abort on process group - allow `otel.py` to initialize loggers in multiple namespaces for each structured loggers - pass `replica_id` to process group so that it can be logged - flag to enable or disable otel logging Reviewed By: d4l3k Differential Revision: D84571482
tushar00jain
force-pushed
the
export-D84571482
branch
from
3e6643b to
93a3a39
Compare
|
This pull request has been merged in b3be7ad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
otel.pyto initialize loggers in multiple namespaces for each structured loggersreplica_idto process group so that it can be loggedDifferential Revision: D84571482