Replace Duration::from_secs(60) to Duration::from_mins(1) #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Differential Revision: D88434166
meta-cla
bot
added
the
CLA Signed
|
@edward-shen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88434166. |
edward-shen
added a commit
to edward-shen/monarch
that referenced
this pull request
Dec 5, 2025
…ch#2066) Summary: X-link: meta-pytorch/torchft#297 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166
edward-shen
added a commit
to edward-shen/monarch
that referenced
this pull request
Dec 5, 2025
…ch#2066) Summary: X-link: meta-pytorch/torchft#297 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166
edward-shen
added a commit
to edward-shen/monarch
that referenced
this pull request
Dec 5, 2025
…ch#2066) Summary: X-link: meta-pytorch/torchft#297 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166
edward-shen
added a commit
to edward-shen/monarch
that referenced
this pull request
Dec 5, 2025
…ch#2066) Summary: X-link: meta-pytorch/torchft#297 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166
edward-shen
added a commit
to edward-shen/monarch
that referenced
this pull request
Dec 5, 2025
…ch#2066) Summary: X-link: meta-pytorch/torchft#297 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
meta-codesync bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
meta-codesync bot
pushed a commit
to WhatsApp/erlang-language-platform
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
meta-codesync bot
pushed a commit
to meta-pytorch/monarch
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 Pull Request resolved: #2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
meta-codesync bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
meta-codesync bot
pushed a commit
to facebookexperimental/reverie
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
|
This pull request has been merged in abcff8a. |
meta-codesync bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Dec 5, 2025
Summary: X-link: meta-pytorch/torchft#297 X-link: meta-pytorch/monarch#2066 Rust 1.91 introduced `Duration::from_mins`. This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_mins`. Reviewed By: dtolnay Differential Revision: D88434166 fbshipit-source-id: e5e86763e0f4cfa6da502d32f1f98ffc198399ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/monarch#2066
Rust 1.91 introduced
Duration::from_mins.This diff replaces some instances of
Duration::from_secswith the correspondingDuration::from_mins.Differential Revision: D88434166