Skip to content

Fix for T247806505 ("Your diff, D88512803, broke one test") #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aorenste wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for T247806505 ("Your diff, D88512803, broke one test") #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions torchft/process_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
AllToAllOptions,
BarrierOptions,
BroadcastOptions,
GroupName,
ReduceOp,
ReduceScatterOptions,
Work,
Expand Down Expand Up @@ -133,7 +134,7 @@ def __init__(self, *args: object, **kwargs: object) -> None:
# pyre-fixme[6]: got object
super().__init__(*args, **kwargs)

self._group_name: Optional[str] = None
self._group_name: Optional[GroupName] = None

# pyre-fixme[14]: inconsistent override
def allgather(
Expand Down Expand Up @@ -313,7 +314,7 @@ def size(self) -> int:
def getBackendName(self) -> str:
raise NotImplementedError("not implemented")

def _register(self, name: str) -> str:
def _register(self, name: str) -> GroupName:
group_name = f"{self.getBackendName()}:{name}"

# This is needed for DeviceMesh and functional collectives to work.
Expand All @@ -332,7 +333,7 @@ def create_pg(
devices.append("xpu")
dist.Backend.register_backend(group_name, create_pg, devices=devices)

return group_name
return GroupName(group_name)

def register(self, name: str) -> "ProcessGroup":
"""
Expand All @@ -355,12 +356,12 @@ def register(self, name: str) -> "ProcessGroup":
)

@property
def group_name(self) -> str:
def group_name(self) -> GroupName:
if self._group_name is None:
raise ValueError("ProcessGroup name not set")
return self._group_name

def _set_group_name(self, name: str) -> None:
def _set_group_name(self, name: GroupName) -> None:
self._group_name = name

def unregister(self) -> None:
Expand Down
Loading