Refactor test for mc_embeddings #3632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Context
---------
Recently, a diff D88826044 was landed that did a internal import inside distributed/tests/test_mc_embedding. The has caused Github tests to fail, and caused other diffs from not landing:
{F1984353292}
See the [commit](https://github.com/meta-pytorch/torchrec/commits/main/) page for more info.
Changes
----------
The tests from that diff were moved to the internal version of `distributed/tests/test_mc_embedding.py`
NOTE: It is concerning that this somehow passed through the test plan, and landed with Github export enabled.
Differential Revision: D89727162
Contributor
|
@Ali-Tehrani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89727162. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Recently, a diff D88826044 was landed that did a internal import inside distributed/tests/test_mc_embedding. The has caused Github tests to fail, and caused other diffs from not landing:
{F1984353292}
See the commit page for more info.
Changes
The tests from that diff were moved to the internal version of
distributed/tests/test_mc_embedding.pyNOTE: It is concerning that this somehow passed through the test plan, and landed with Github export enabled.
Differential Revision: D89727162