Fix pyrefly type errors in test_embedding_modules.py#3791
Open
spmex wants to merge 1 commit intometa-pytorch:mainfrom
Open
Fix pyrefly type errors in test_embedding_modules.py#3791spmex wants to merge 1 commit intometa-pytorch:mainfrom
spmex wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: Fix pyrefly type checking test [281475269894183](https://www.internalfb.com/intern/test/281475269894183). Added `# pyrefly: ignore[bad-argument-type]` before 7 `.qconfig = torch.quantization.QConfig(...)` assignments. Pyrefly types `nn.Module.__setattr__` as accepting `Module | Tensor`, so assigning a `QConfig` triggers a type error. Differential Revision: D93962697
meta-cla
bot
added
the
CLA Signed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix pyrefly type checking test 281475269894183.
Added
# pyrefly: ignore[bad-argument-type]before 7.qconfig = torch.quantization.QConfig(...)assignments. Pyrefly typesnn.Module.__setattr__as acceptingModule | Tensor, so assigning aQConfigtriggers a type error.Differential Revision: D93962697