Unify hash_mc_evictions.py (#3866)#3866
Open
Ali-Tehrani wants to merge 1 commit intometa-pytorch:mainfrom
Open
Unify hash_mc_evictions.py (#3866)#3866Ali-Tehrani wants to merge 1 commit intometa-pytorch:mainfrom
Ali-Tehrani wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@Ali-Tehrani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96242594. |
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 12, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 12, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 12, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 12, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
meta-codesync
bot
changed the title
Ali-Tehrani
force-pushed
the
export-D96242594
branch
from
8009500 to
7fbbf1f
Compare
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 13, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
Ali-Tehrani
added a commit
to Ali-Tehrani/torchrec
that referenced
this pull request
Mar 13, 2026
Summary:
Context
---------
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
------------------
- The only difference between internal and OSS, is one assertion statement.
- Internal is imported in over 100 different places.
- Inside Internal:
- Added a simple depreciated warning, and imported from OSS, in this case.
- Removed the internal tests: `fb/modules/tests/test_hash_mc_evictions.py`
- Changed all internal imports for fb/ within TREC to be OSS.
- External imports will be removed in a seperate diff
Differential Revision: D96242594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
The goal is to remove hash_mc_evictions to unify internal with OSS.
Implementation
fb/modules/tests/test_hash_mc_evictions.pyDifferential Revision: D96242594