torchx support early validation before workspace build#1007
Merged
facebook-github-bot merged 1 commit intometa-pytorch:mainfrom Feb 11, 2025
Merged
torchx support early validation before workspace build#1007facebook-github-bot merged 1 commit intometa-pytorch:mainfrom
facebook-github-bot merged 1 commit intometa-pytorch:mainfrom
Conversation
Summary: add `_pre_build_validate()` hook for torchx scheduler to perform app validation before build workspace step. This earlier validation enables detecting issue sooner without the need to wait for build workspace to complete. This change only exposes the pre_build_validate() hook for torchx scheduler and there is no change to existing behavior (validation will continue to perform after build workspace if required). Subsequent change will change the behavior within specific scheduler if validation can be moved from validate to pre_build_validate. additional change to add event logging for build_workspace_and_update_role call. Differential Revision: D69463377
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69463377 |
lgarg26
approved these changes
Feb 11, 2025
ishachirimar
approved these changes
Feb 11, 2025
Contributor
ishachirimar
left a comment
ishachirimar
left a comment
There was a problem hiding this comment.
lgtm - some of the schedulers log from within build_workspace_and_update_role but doesn't look like a concern for duplication
facebook-github-bot
merged commit 1e6a2dd
into
meta-pytorch:main
21 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
add
_pre_build_validate()hook for torchx scheduler to perform app validation before build workspace step. This earlier validation enables detecting issue sooner without the need to wait for build workspace to complete. This change only exposes the pre_build_validate() hook for torchx scheduler and there is no change to existing behavior (validation will continue to perform after build workspace if required). Subsequent change will change the behavior within specific scheduler if validation can be moved from validate to pre_build_validate.additional change to add event logging for build_workspace_and_update_role call.
Differential Revision: D69463377