Remove notebook/gallery support from docs build#1240
Merged
meta-codesync[bot] merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93899179. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 83 83
Lines 7025 7025
=======================================
Hits 6498 6498
Misses 527 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
a756e75 to
e39fd64
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
e39fd64 to
e4c4956
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
e4c4956 to
6f1daee
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
6f1daee to
83bad32
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
83bad32 to
99a376e
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
99a376e to
4b26a02
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
4b26a02 to
73d893e
Compare
Summary: NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs. ## What Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown. ## Context The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features. Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout. Reviewed By: AbishekS Differential Revision: D93899179
73d893e to
cde07cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: nbsphinx was used to build notebook gallery for
torchx/examples/app(which is effectively a dead module) so removing all the notebook building complexity in docs.What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.
Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.
Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.
Reviewed By: AbishekS
Differential Revision: D93899179