Skip to content

Comments

Remove notebook/gallery support from docs build#1240

Merged
meta-codesync[bot] merged 1 commit intomainfrom
export-D93899179
Feb 22, 2026
Merged

Remove notebook/gallery support from docs build#1240
meta-codesync[bot] merged 1 commit intomainfrom
export-D93899179

Conversation

@kiukchung
Copy link
Contributor

Summary:
NOTE: nbsphinx was used to build notebook gallery for torchx/examples/app (which is effectively a dead module) so removing all the notebook building complexity in docs.

What

Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

Context

The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 21, 2026

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93899179.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.49%. Comparing base (c41a375) to head (cde07cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1240   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          83       83           
  Lines        7025     7025           
=======================================
  Hits         6498     6498           
  Misses        527      527           
Flag Coverage Δ
unittests 92.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2026
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
Summary:

NOTE: nbsphinx was used to build notebook gallery for `torchx/examples/app` (which is effectively a dead module) so removing all the notebook building complexity in docs.

## What
Remove nbsphinx, sphinx-gallery, papermill, and all notebook-related infrastructure from the TorchX documentation build. Convert quickstart.md and custom_components.md from jupytext to plain markdown.

## Context
The notebook/gallery infrastructure added complexity and dependencies (pandoc, ipykernel, jupytext, etc.) but the notebooks were not being actively maintained. The two markdown files that used jupytext frontmatter (quickstart.md, custom_components.md) don't use any notebook-specific features.

Also adds TORCHX_DOCS_FBCODE env var override to conf.py so docs can be built in OSS mode from an fbcode checkout.

Reviewed By: AbishekS

Differential Revision: D93899179
@meta-codesync meta-codesync bot merged commit 029982c into main Feb 22, 2026
17 of 19 checks passed
@meta-codesync meta-codesync bot deleted the export-D93899179 branch February 22, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants