Skip to content

Explicitly zero grad in flash_attention Triton Bench #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Explicitly zero grad in flash_attention Triton Bench #683

wants to merge 2 commits into from

Conversation

@sryap
Copy link
Contributor

@sryap sryap commented Dec 3, 2025

Summary:
Explicitly zero grad because simply setting grad to None does not
eliminate the grad accumulation step

Reviewed By: y-sq

Differential Revision: D85325066

@sryap sryap temporarily deployed to docker-s3-upload December 3, 2025 23:06 — with GitHub Actions Inactive
@sryap sryap temporarily deployed to docker-s3-upload December 3, 2025 23:06 — with GitHub Actions Inactive
@meta-cla meta-cla bot added the cla signed label Dec 3, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 3, 2025

@sryap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85325066.

sryap added 2 commits December 3, 2025 16:34
@sryap @facebook-github-bot
Generate GPU L2 size inputs in flash_attention Triton Bench (#681)
ff17272 
Summary:

Add an option to generate inputs as large as the GPU L2 cache size to
avoid an explicit cache clearing in every iteration

Reviewed By: henrylhtsang

Differential Revision: D85318459
@sryap @facebook-github-bot
Explicitly zero grad in flash_attention Triton Bench (#683)
2ffe770 
Summary:

Explicitly zero grad because simply setting grad to None does not
eliminate the grad accumulation step

Reviewed By: y-sq

Differential Revision: D85325066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sryap @facebook-github-bot