Migrated UserViewmodel to shared module#765
Open
nirvan73 wants to merge 15 commits into
Open
Conversation
nirvan73
force-pushed
the
migrate/user-viewmodel
branch
2 times, most recently
from
1d0dbe9 to
f117ea5
Compare
…edRepositoryModule
…ered it under sharedRepositoryModule
… sharedViewModelModule
… sharedViewModelModule
…de SharedRepositoryModule
nirvan73
force-pushed
the
migrate/user-viewmodel
branch
from
468c313 to
48be7b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base PR:- #758 , #760
Rebased with latest upstream/cmp, and this branch consists every commit from the base branches. Needed
PlaylistDataRepository, so had to take base #760 completely.This PR fixes #702 migrates
UserViewModelto shared module.Key Changes:-
UserListensPagingSourceto shared module.UserRepositoryand its impl to shared module and registered it insidesharedRepositoryModule.UserViewmodelto shared module and registered it insidesharedViewmodelModule.