Skip to content

PICARD-3069: Add disambiguation comment to search dialog results #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

zas
Copy link
Collaborator

@zas zas commented May 21, 2025

  • for album, artist & track
  • column is titled "Comment" rather than "Disambiguation", shorter (in English) and more common

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

In Search dialog results no disambiguation is displayed so it makes difficult to choose the correct entry in many cases.

Solution

Album:
image

Artist:
image

Track:
image

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested review from phw and rdswift May 21, 2025 08:49
- for album, artist & track
- column is titled "Comment" rather than "Disambiguation", shorter (in English) and more common
@zas zas requested a review from phw May 21, 2025 10:32
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 93724f2 into metabrainz:master May 21, 2025
51 checks passed
@zas zas deleted the PICARD-3069 branch May 21, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants