test(docker): enable Python→C# integration test in cli image#842
Open
G00dS0ul wants to merge 1 commit into
Open
test(docker): enable Python→C# integration test in cli image#842G00dS0ul wants to merge 1 commit into
G00dS0ul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enables the C# section of the Python integration test in
tools/docker/tests/scripts/index.py, which was previously commented out.The test loads
Sum.csvia the C# loader and asserts:sum_cs(3, 4) == 7greet_cs('MetaCall') == 'Hello MetaCall from C#!'This PR is expected to FAIL in CI. It is intentionally opened to surface the
cs_loader init failure in the
metacall/core:cliruntime image so we can trackand fix it separately (coordinated with @viferga).
Root cause of the failure
On C# loader init,
netcore_linux::ConfigAssemblyName()builds the TrustedPlatform Assemblies list by iterating the runtime/assembly directory, which is
configured to
/usr/local/metacall/build. That path exists in the dev/buildimage but not in the stripped
runtime/cliimage, so the directory scanfails.
Decoded stack trace from the published
metacall/core:cliimage:Notes:
:cliimage predates Fix cs_loader process crash on missing TPA directory (#789) #831, so it still hits the throwingdirectory_iterator(hard abort / SIGABRT). With Fix cs_loader process crash on missing TPA directory (#789) #831'sAddFilesFromDirectoryToTpaListerror_code guard now ondevelop, a cli imagerebuilt from source instead fails gracefully:
metacall_load_from_file('cs', ...)returns false and the Python assertion fails cleanly. Either way the test is red.
actual install location in the runtime image instead of the build dir.
index.jscontains the same commented-out C# block; left commented in thisPR and deferred.
Relates to #123 (Make C# Loader production ready).
Type of change
Checklist