Skip to content

fix: resolve TODO - use handle scope in RenderExec::exec() for load #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aditya-8787 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve TODO - use handle scope in RenderExec::exec() for load #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/metassr-build/src/server/render_exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ impl RenderExec {
impl Exec for RenderExec {
type Output = String;
fn exec(&self) -> Result<Self::Output> {
// let path = self.0.strip_prefix(current_dir()?)?;
// TODO: should the scope of this loading be a handle or None ?
if let Err(e) = load::from_single_file(load::Tag::NodeJS, &self.path, None) {
// Each RenderExec uses its own handle to isolate the loaded script
// in a separate scope, preventing function name collisions across pages.
let mut handle = load::Handle::default();
if let Err(e) = load::from_single_file(load::Tag::NodeJS, &self.path, Some(&mut handle)) {
return Err(anyhow!(
"Cannot load render script: {e:?} \n path: {:#?}",
self.path
Expand Down