Skip to content

Make cookie domain settable via config#1488

Merged
oalders merged 1 commit into
masterfrom
oalders/cookie-domain
Jun 14, 2026
Merged

Make cookie domain settable via config#1488
oalders merged 1 commit into
masterfrom
oalders/cookie-domain

Conversation

@oalders

@oalders oalders commented Jun 14, 2026

Copy link
Copy Markdown
Member

Right now auth seem to be using both fastapi.metacpan.org and api.metacpan.org

Try to have a more robust way of handling this.

@oalders oalders force-pushed the oalders/cookie-domain branch from 0549ed6 to 1522bf2 Compare June 14, 2026 12:06
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (12bcd70) to head (1522bf2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   63.55%   63.65%   +0.09%     
==========================================
  Files         137      137              
  Lines        4467     4468       +1     
  Branches      670      671       +1     
==========================================
+ Hits         2839     2844       +5     
+ Misses       1374     1370       -4     
  Partials      254      254              
Files with missing lines Coverage Δ
lib/MetaCPAN/Server/Controller/Login.pm 42.42% <100.00%> (+8.04%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oalders oalders merged commit ee062af into master Jun 14, 2026
5 checks passed
@oalders oalders deleted the oalders/cookie-domain branch June 14, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants