Try to normalize the github workflows #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/build-normalize
branch
3 times, most recently
from
dfe534c to
24cbada
Compare
|
Along with all of the other changes, this also separates out the tidy checks into a separate action run. #3048 also tries to address this, so whichever PR is merged second will need some adjustment. I included it in this PR because the |
Update the GitHub Actions configs to try to get closer to a standard setup we can use across multiple repos. Switch from jamestrousdale/github-app-jwt-token to actions/create-github-app-token. Should be more trustworthy and likely better maintained. Use docker/build-push-action for building docker images rather than running the commands manually. Use docker/metadata-action to provide extra metadata, as well as picking the tags we will push. This allows combining the 'deployment' and 'production' build workflows. Update the perl and node versions used when testing without Docker to match the versions used in Docker.
Devel::Cover::Report::Codecov is deprecated. Instead, use the codecovbash report type to generate the json to upload, and upload it using codecov/codecov-action.
haarg
force-pushed
the
haarg/build-normalize
branch
from
ebd3045 to
02bfec8
Compare
|
This one failed the formatting check, so I think it still needs a tweak. We can remove all references to tidyall at this point, I think. |
oalders
reviewed
May 15, 2024
haarg
force-pushed
the
haarg/build-normalize
branch
from
02bfec8 to
d83d532
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
==========================================
+ Coverage 71.75% 71.79% +0.04%
==========================================
Files 70 70
Lines 2411 2411
Branches 338 338
==========================================
+ Hits 1730 1731 +1
+ Misses 555 554 -1
Partials 126 126 |
haarg
force-pushed
the
haarg/build-normalize
branch
8 times, most recently
from
bda0413 to
5366d58
Compare
haarg
force-pushed
the
haarg/build-normalize
branch
from
5366d58 to
cf6def9
Compare
oalders
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to get closer to a consistent setup for GitHub workflows. Use actions that can be shared across all of our repos and try to use more 'official' actions.