Better caching and serve from cache more #3374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
previously approved these changes
Jun 4, 2025
oalders
force-pushed
the
leo/better_cache
branch
3 times, most recently
from
8596da9 to
8b9ac53
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3374 +/- ##
==========================================
+ Coverage 73.37% 73.48% +0.11%
==========================================
Files 68 67 -1
Lines 2385 2346 -39
Branches 334 331 -3
==========================================
- Hits 1750 1724 -26
+ Misses 507 496 -11
+ Partials 128 126 -2
🚀 New features to boost your workflow:
|
ranguard
force-pushed
the
leo/better_cache
branch
from
115d573 to
9c8e023
Compare
haarg
reviewed
Jun 7, 2025
lib/MetaCPAN/Web/Controller/Pod.pm
Outdated
| @@ -40,6 +40,7 @@ sub view : Private { | |||
| my $release = $c->stash->{release}; | |||
|
|
|||
| if ( $data->{directory} ) { | |||
| $c->cdn_max_age('1y'); | |||
There was a problem hiding this comment.
This can end up being a redirect from a non-versioned path to a versioned path, and it doesn't have any surrogate keys so it won't get purged.
oalders
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IF reach the main /end we enable
These only take effect if
cdn_max_agehas been setAlso added caching on /search - which is where most of our traffic ends up
https://www.fastly.com/documentation/guides/concepts/edge-state/cache/stale/ shows the timeline