Skip to content

Add SitemapReader originally developed in OERSI - #469

Draft
fsteeg wants to merge 1 commit into
masterfrom
sitemapReader
Draft

Add SitemapReader originally developed in OERSI#469
fsteeg wants to merge 1 commit into
masterfrom
sitemapReader

Conversation

@fsteeg

@fsteeg fsteeg commented Sep 22, 2022

Copy link
Copy Markdown
Member

Reads sitemap from URL, sends each loc URL to the receiver.

e.g. "https://hoou.de/sitemap.xml" | read-sitemap | open-http ... in a Flux workflow to process every document linked in the sitemap.

Supports paging via from= query string parameter in the sitemap URL.

Assigning @dr0i for code review due to the (albeit loose) paging relation to #464.

We don't have a dedicated issue for this, maybe @TobiasNx could do functional review here?

Reads sitemap from URL, sends each `loc` URL to the receiver.

e.g. `"https://hoou.de/sitemap.xml" | read-sitemap | open-http ...`
in a Flux workflow to process every document linked in the sitemap.

Supports paging via `from=` query string parameter (see #464)

See:

https://en.wikipedia.org/wiki/Sitemaps
https://gitlab.com/oersi/oersi-etl/-/issues/4
https://gitlab.com/oersi/oersi-etl/-/issues/17
@fsteeg
fsteeg requested a review from dr0i September 22, 2022 15:47
@dr0i dr0i removed their assignment Sep 23, 2022
@fsteeg

fsteeg commented Sep 23, 2022

Copy link
Copy Markdown
Member Author

Discussed in our planning meeting: we're putting this on hold to investigate if we actually need this kind of specific module for reading sitemaps, or if we can build something based on existing modules and the upcoming paging support (#464).

@sonarqubecloud

sonarqubecloud Bot commented Mar 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TobiasNx

TobiasNx commented May 5, 2025

Copy link
Copy Markdown
Contributor

@fsteeg i was thinking about this module again. In the last years we saw that pagination mechanism are pretty different. Does it now make sense to move the oersi.sitemapreader to core?

@fsteeg

fsteeg commented May 5, 2025

Copy link
Copy Markdown
Member Author

@fsteeg i was thinking about this module again. In the last years we saw that pagination mechanism are pretty different. Does it now make sense to move the oersi.sitemapreader to core?

Do you need the sitemap reader in a non-OERSI context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants