Upgrade Log4j dependency to version 2.x.#748
Merged
Merged
Conversation
…afacture-fix#198) Apparently, no longer needed since a7526fe (bisected; originally introduced in eecfdae). ``` > Task :metafix:jmh [...] SLF4J: Found binding in [jar:file:.../metafix/build/libs/metafix-0.2.0-SNAPSHOT-jmh.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:.../gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-simple/1.7.21/.../slf4j-simple-1.7.21.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory] ```
Extending 5bea2c5 to include module and group; as well as unifying API dependency.
- Changed logging provider from `slf4j-log4j12` to `log4j-slf4j2-impl`.
- Renamed and migrated configuration files (`log4j.xml` -> `log4j2.xml`) as well as system property (`log4j.configuration` -> `log4j2.configurationFile`).
- Renamed console appenders from `stdout`/`external-stdout` to `CONSOLE`/`EXTERNAL_CONSOLE`.
- Upgraded `slf4j2-mock` dependency to next minor version (although not required).
- Avoided multiple logging providers from `log4j-slf4j2-impl` in combination with `slf4j2-mock` (see below):
- Dropped `testRuntimeOnly` dependency for `metafix` project.
- Moved `implementation` dependency for `mwe2` configuration to proper `dependencies` block.
With both logging providers (even if only for `mwe2`):
```
> Task :metafix:test
MetafixScriptTest > shouldAbortProcessOnExecutionException() STANDARD_ERROR
SLF4J(W): Class path contains multiple SLF4J providers.
SLF4J(W): Found provider [org.apache.logging.slf4j.SLF4JServiceProvider@62ba3045]
SLF4J(W): Found provider [org.simplify4u.slf4jmock.MockServiceProvider@397bd46b]
SLF4J(W): See https://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J(I): Actual provider is of type [org.apache.logging.slf4j.SLF4JServiceProvider@62ba3045]
```
Without any logging provider for `mwe2`:
```
> Task :metafix:generateXtextLanguage
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
```
Closed
Member
Author
|
@fsteeg: Maybe you can already start your code review while @TobiasNx finishes his functional review? It doesn't look like there are any major complications to be expected at this point. |
fsteeg
approved these changes
Mar 24, 2026
Member
fsteeg
left a comment
fsteeg
left a comment
There was a problem hiding this comment.
Great consolidation / cleanup in addition to the upgrade!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #739.
The first three commits aren't directly related to the issue at hand, they just surfaced in the vicinity of the actual logging changes (final commit).
slf4j-log4j12tolog4j-slf4j2-impl.log4j.xml->log4j2.xml) as well as system property (log4j.configuration->log4j2.configurationFile).stdout/external-stdouttoCONSOLE/EXTERNAL_CONSOLE.slf4j2-mockdependency to next minor version (although not required).log4j-slf4j2-implin combination withslf4j2-mock(see below):testRuntimeOnlydependency formetafixproject.implementationdependency formwe2configuration to properdependenciesblock.With both logging providers (even if only for
mwe2):Without any logging provider for
mwe2: