Skip to content

Metamorph instantiation exception when using "urlencode"#749

Merged
dr0i merged 2 commits into
masterfrom
705-fixUrlencode
Mar 9, 2026
Merged

Metamorph instantiation exception when using "urlencode"#749
dr0i merged 2 commits into
masterfrom
705-fixUrlencode

Conversation

@dr0i
Copy link
Copy Markdown
Member

@dr0i dr0i commented Mar 9, 2026

Fixes #705.

This prevents a Metamorph instantiation exception.

- add metamorph test

This prevents a Metamorph instantiation exception.
@dr0i dr0i requested review from TobiasNx and blackwinter and removed request for blackwinter March 9, 2026 10:40
@dr0i
Copy link
Copy Markdown
Member Author

dr0i commented Mar 9, 2026

  1. functional review: @TobiasNx
  2. if 1) is fine: code review: @blackwinter

Copy link
Copy Markdown
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that you added a test for urlencode (the first one!). You might also go one step further and test this option explicitly (plusforspace="false").

@TobiasNx
Copy link
Copy Markdown
Contributor

TobiasNx commented Mar 9, 2026

I tested

<?xml version="1.0" encoding="UTF-8"?>
<metamorph xmlns="http://www.culturegraph.org/metamorph" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	version="1">
	<rules>
		<data source="_id" name="id"/>
		<data source="a" name="title">
			<urencode/>
		</data>
	</rules>
</metamorph>
<?xml version="1.0" encoding="UTF-8"?>
<metamorph xmlns="http://www.culturegraph.org/metamorph" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	version="1">
	<rules>
		<data source="_id" name="id"/>
		<data source="a" name="title">
			<urlencode  plusforspace="false"/>
		</data>
	</rules>
</metamorph>
uri_encode("test", plus_for_space:"false", safe_chars:"")

All worked! ✔️

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Mar 9, 2026
@dr0i dr0i merged commit 27adf02 into master Mar 9, 2026
2 checks passed
@dr0i dr0i deleted the 705-fixUrlencode branch March 9, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<urlencode/> no longer works since 5.7.0

3 participants