Skip to content

Adjust flux example link labelling#753

Merged
TobiasNx merged 2 commits into
masterfrom
fluxExampleLinkLabelling
Apr 13, 2026
Merged

Adjust flux example link labelling#753
TobiasNx merged 2 commits into
masterfrom
fluxExampleLinkLabelling

Conversation

@TobiasNx
Copy link
Copy Markdown
Contributor

Currently all links are labelled as playground example, this change also adds labelling for runner examples via new conditional.

@TobiasNx TobiasNx requested a review from dr0i March 12, 2026 14:34
@dr0i
Copy link
Copy Markdown
Member

dr0i commented Mar 12, 2026

Build fails with "HelpPrinter.java:133: error: illegal start of expression"

You cannot do this:
if (examplesEntry[2] == *"github"*) {

@blackwinter
Copy link
Copy Markdown
Member

Please add pull requests without a corresponding issue to the Metafacture project.

Currently all links are labelled as playground example, this change also adds labelling for runner examples via new conditional.
@TobiasNx TobiasNx force-pushed the fluxExampleLinkLabelling branch from 1d186ad to dde430d Compare March 12, 2026 15:05
@TobiasNx
Copy link
Copy Markdown
Contributor Author

Thanks, I assumed that this was the flux.sh and so an bash script ....
Now this should be correct.

@TobiasNx TobiasNx moved this to Review in Metafacture Mar 12, 2026
Comment thread metafacture-flux/src/main/java/org/metafacture/flux/HelpPrinter.java Outdated
@blackwinter
Copy link
Copy Markdown
Member

BTW: The only non-Playground example at the moment contains text after the link. It's not usable as-is!

@TobiasNx
Copy link
Copy Markdown
Contributor Author

BTW: The only non-Playground example at the moment contains text after the link. It's not usable as-is!

Thanks. I intend to update this one and add missing examples.

@dr0i dr0i removed their assignment Mar 16, 2026
Copy link
Copy Markdown
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

…r.java

Co-authored-by: Jens Wille <jens.wille@hbz-nrw.de>
@katauber katauber requested a review from blackwinter April 13, 2026 09:17
@katauber katauber assigned blackwinter and unassigned TobiasNx Apr 13, 2026
@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Apr 13, 2026
@TobiasNx TobiasNx merged commit a7ea928 into master Apr 13, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Metafacture Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants