Skip to content

merge-batch-stream: Make batchsize configurable in Flux - #784

Open
TobiasNx wants to merge 1 commit into
masterfrom
782-makeBatchsizeConfigureableInFlux
Open

merge-batch-stream: Make batchsize configurable in Flux#784
TobiasNx wants to merge 1 commit into
masterfrom
782-makeBatchsizeConfigureableInFlux

Conversation

@TobiasNx

Copy link
Copy Markdown
Contributor

Resolves #782

Reuse adjustment from ObjectSleeper.java 18b6ae0

Reuse adjustment from ObjectSleeper.java 18b6ae0
TobiasNx added a commit to TobiasNx/notWorkingFlux that referenced this pull request Aug 25, 2026
@TobiasNx

Copy link
Copy Markdown
Contributor Author

@dr0i could you do an functional review? I also added a test workflow here: TobiasNx/notWorkingFlux@f841b1f

@blackwinter

blackwinter commented Aug 25, 2026

Copy link
Copy Markdown
Member

Functional review is done on the issue. You have to assign @dr0i there (and move the issue to the review status).

@blackwinter blackwinter assigned blackwinter and unassigned dr0i Aug 25, 2026
@blackwinter
blackwinter removed the request for review from dr0i August 25, 2026 11:13

@blackwinter blackwinter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an integration test so we can be sure not to introduce a regression in the future.

@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Aug 25, 2026
@TobiasNx

Copy link
Copy Markdown
Contributor Author

Please add an integration test so we can be sure not to introduce a regression in the future.

There already exists an tests for batchSize. But I do not know how to build a test that checks for a specific datatype:

@Test
public void testShouldMergeNConsecutiveRecords() {
batchMerger.setBatchSize(2);

@blackwinter

Copy link
Copy Markdown
Member

But I do not know how to build a test that checks for a specific datatype

Exactly, that's why I said integration test. There you specify a Flux workflow which uses the new setter - which is the actual goal of this pull request.

@TobiasNx

Copy link
Copy Markdown
Contributor Author

But I do not know how to build a test that checks for a specific datatype

Exactly, that's why I said integration test. There you specify a Flux workflow which uses the new setter - which is the actual goal of this pull request.

Should I add this integration test in context of metafix (metafix/src/test/resources/org/metafacture/metafix/integration)?

@blackwinter

Copy link
Copy Markdown
Member

Yes, that's the only place we currently have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge-batch-stream : Cannot configure option batchSize in flux

3 participants