First language server approach - #2
Merged
Merged
Conversation
…lsp into 1-firstApproach
katauber
marked this pull request as ready for review
February 6, 2026 13:19
Member
|
Cool, got it working with the sample web editor. Pushed some tweaks to the README in 9f9b2d6. Will continue with code review. |
fsteeg
approved these changes
Feb 10, 2026
fsteeg
left a comment
fsteeg
left a comment
Member
There was a problem hiding this comment.
As we briefly discussed offline the other day, I've suggested a way to replace the nested loop with a more functional approach.
I've also inlined some local variables, removed the unused client field, and added /bin to .gitignore.
From my point of view we could merge and continue with setting up some tests.
Member
Author
|
Thank you very much for your improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this approach there is a simple language server which offers autocompletion based on the annotations in Metafacture (used annotations: FluxCommand, In, Out, Description).
The project is based on https://github.com/NipunaMarcus/hellols/tree/websocket-launcher and uses a websocket to communicate.
For a simple test setup use this editor. If you type the some letters there should be suggestions of flux commands containing also the descritiption, in and out annotations.
Resolves #1