-
Notifications
You must be signed in to change notification settings - Fork 26
Revival + Update (AUT 25) #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
proffapt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bruhh
Please have commits, for a sane commit history. Makes the reviewer understand the flow of changes.
sorry, i kinda did everything together, will ensure from next time |
|
build is failing |
shikharish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doesnt matter. im gonna squash and merge anyway :) |
All in favor of removing his write privileges react 👍. |
|
Baccho ko mat do |
Description
Since 2024 (admission batch), a new curriculum has been introduced wherein first year's curriculum is equivalent to other years. Each department has a predefined curriculum (the curriculum is no longer common), and no physics/chemistry semester type creation exists anymore. This makes the first years curriculum similar to other years. ERP also reports first year courses information in the same way it does for the courses of other years. This allows us to get rid of the separate handling of first year courses (via parsing a PDF), and just use the ERP scraper to get info about all the courses.
This PR
first_year_scraperand renamesother_years_scraperto justscrapercreate-react-app(deprecated) tovite.*iitkgp-erp-login-godependency (the version being used was buggy)*There was also a PWA and an associated service worker, I have not changed any code related to the service worker. Most probably it won't work since vite natively does not support service workers.
Fixes #85
Type of change
Checklist: