Skip to content

Conversation

@dipamsen
Copy link
Member

@dipamsen dipamsen commented Jul 29, 2025

Description

Since 2024 (admission batch), a new curriculum has been introduced wherein first year's curriculum is equivalent to other years. Each department has a predefined curriculum (the curriculum is no longer common), and no physics/chemistry semester type creation exists anymore. This makes the first years curriculum similar to other years. ERP also reports first year courses information in the same way it does for the courses of other years. This allows us to get rid of the separate handling of first year courses (via parsing a PDF), and just use the ERP scraper to get info about all the courses.

This PR

  1. Removes first_year_scraper and renames other_years_scraper to just scraper
  2. Migrates from create-react-app (deprecated) to vite.*
  3. Bumps iitkgp-erp-login-go dependency (the version being used was buggy)
  4. Fixes a frontend bug which made it impossible to select "Monday" on the day dropdown (0 is falsy amirite)
  5. Updates the data for semester Autumn 2025

*There was also a PWA and an associated service worker, I have not changed any code related to the service worker. Most probably it won't work since vite natively does not support service workers.

Fixes #85

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruhh

Please have commits, for a sane commit history. Makes the reviewer understand the flow of changes.

@dipamsen
Copy link
Member Author

dipamsen commented Jul 29, 2025

Please have commits, for a sane commit history.

sorry, i kinda did everything together, will ensure from next time

@proffapt
Copy link
Member

build is failing

Copy link
Member

@shikharish shikharish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shikharish
Copy link
Member

bruhh

Please have commits, for a sane commit history. Makes the reviewer understand the flow of changes.

doesnt matter. im gonna squash and merge anyway :)

@shikharish shikharish merged commit 13ddd30 into metakgp:master Jul 31, 2025
1 check passed
@harshkhandeparkar
Copy link
Member

bruhh
Please have commits, for a sane commit history. Makes the reviewer understand the flow of changes.

doesnt matter. im gonna squash and merge anyway :)

All in favor of removing his write privileges react 👍.

@proffapt
Copy link
Member

Baccho ko mat do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First year scraper is outdated

4 participants